Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash to Pod::Platform #109

Closed
wants to merge 1 commit into from
Closed

Add hash to Pod::Platform #109

wants to merge 1 commit into from

Conversation

segiddins
Copy link
Member

No description provided.

@alloy
Copy link
Member

alloy commented Apr 12, 2014

Can you please include a test case that demonstrates why this is needed? And assuming it fixes/improves some situation, also add a CHANGELOG entry?

@segiddins
Copy link
Member Author

@alloy I was having some issues using Platforms as keys in a Hash. I don't think this actually fixed the problem, so I'm closing the PR, but would appreciate some help figuring out why they can't be used as keys.

@segiddins segiddins closed this Apr 12, 2014
@alloy
Copy link
Member

alloy commented Apr 13, 2014

Can you create a failing test case that demonstrates exactly what you want?

@segiddins
Copy link
Member Author

hash = {}
platform = Pod::Platform.new :ios
platform_1 = Pod::Platform.new :ios
hash[platform] = 1
hash[platform_1].should == 1 # but instead it is nil

@alloy
Copy link
Member

alloy commented Apr 14, 2014

Gotcha, I’ll look into it later today!

alloy added a commit that referenced this pull request Apr 15, 2014
@alloy
Copy link
Member

alloy commented Apr 15, 2014

@segiddins I pushed a fix.

@segiddins segiddins deleted the platform-hash branch May 2, 2014 03:05
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants